Skip to content

Conversation

tom-andersen
Copy link
Contributor

@tom-andersen tom-andersen commented Sep 20, 2024

Internal change to Firestore.

Prepare persistence of session token. This will be used in future work to support database name resuse.

This was reverted to delay release: #13719

@tom-andersen tom-andersen requested a review from wu-hui September 24, 2024 14:47
@tom-andersen tom-andersen marked this pull request as ready for review September 24, 2024 14:47
Copy link
Contributor

@wu-hui wu-hui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor nits, please do fix them before merging.

LGTM in the meantime.

@wu-hui wu-hui assigned tom-andersen and unassigned wu-hui Sep 24, 2024
@tom-andersen tom-andersen merged commit 2893101 into main Sep 25, 2024
34 checks passed
@tom-andersen tom-andersen deleted the tomandersen/sessionTokenPersistence branch September 25, 2024 13:09
@@ -1,5 +1,6 @@
# Unreleased
- [changed] Improve efficiency of memory persistence when processing a large number of writes. (#13572)
- [changed] Prepare Firestore cache to support session token.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change missed yesterday's code freeze. Please move to unreleased.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants